feat: Docker image override with env, update tests, constraint v1.24.3#24
Merged
feat: Docker image override with env, update tests, constraint v1.24.3#24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
We should be able to override phpmyadmin image with
.ddev/.env.phpmyadminHow This PR Solves The Issue
--phpmyadmin-docker-imageflag.5instead of5.2.0- there was some bug with 5.2.1, and newer phpMyAdmin didn't work with Gitpod (see Pin phpmyadmin to 5.2.0, fixes #17 #18), I rechecked it again, the current 5.2.2 works fine with Gitpod.dbservice before installing the add-on.Manual Testing Instructions
Review https://github.com/ddev/ddev-phpmyadmin/blob/20250411_stasadev_upstream_updates/README.md
Automated Testing Overview
Release/Deployment Notes