-
-
Notifications
You must be signed in to change notification settings - Fork 34
blog: update DDEV Add-on Maintenance Guide, fixes #468 #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🌐 Fork Preview for PR #473 https://pr-473.ddev-com-fork-previews.pages.dev This preview updates automatically when you push changes to your fork. |
rfay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
|
PR closed. The Cloudflare Pages preview is no longer updated. |
tyler36
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you for including links to the original PRs and examples.
|
|
||
| - https://github.com/ddev/ddev-varnish/blob/main/docker-compose.varnish.yaml | ||
|
|
||
| It's also useful to check if shell is available in the `tests/test.bats` file (where `service` is the name of the service container you want to test): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line feels strange to me but I'm not sure why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I explained it more clearly in #474
The Issue
How This PR Solves The Issue
Adds links to docs and examples.
Manual Testing Instructions
https://pr-473.ddev-com-fork-previews.pages.dev/blog/ddev-add-on-maintenance-guide/
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes