Skip to content

Conversation

@stasadev
Copy link
Member

@stasadev stasadev commented Nov 19, 2025

The Issue

How This PR Solves The Issue

Adds links to docs and examples.

Manual Testing Instructions

https://pr-473.ddev-com-fork-previews.pages.dev/blog/ddev-add-on-maintenance-guide/

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev stasadev requested a review from rfay November 19, 2025 13:50
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

🌐 Fork Preview for PR #473

https://pr-473.ddev-com-fork-previews.pages.dev

This preview updates automatically when you push changes to your fork.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@stasadev stasadev merged commit 7a040d0 into ddev:main Nov 19, 2025
4 checks passed
@github-actions
Copy link

PR closed. The Cloudflare Pages preview is no longer updated.

@stasadev stasadev deleted the 20251119_stasadev_addons branch November 19, 2025 13:59
Copy link
Contributor

@tyler36 tyler36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for including links to the original PRs and examples.


- https://github.com/ddev/ddev-varnish/blob/main/docker-compose.varnish.yaml

It's also useful to check if shell is available in the `tests/test.bats` file (where `service` is the name of the service container you want to test):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line feels strange to me but I'm not sure why.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I explained it more clearly in #474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants