fix(blog): use original filename for GitHub edit URL#528
Merged
Conversation
Fixes issue where blog posts with dots in filename (e.g., release-v1.25.0.md) had incorrect edit URLs. Astro's entry.id removes dots for URL safety, so we now extract the original filename from entry.filePath instead. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
🌐 Fork Preview for PR #528 https://pr-528.ddev-com-fork-previews.pages.dev This preview updates automatically when you push changes to your fork. |
|
PR closed. The Cloudflare Pages preview is no longer updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
404 link to https://github.com/ddev/ddev.com/tree/main/src/content/blog/release-v1250.md
How This PR Solves The Issue
Fixes issue where blog posts with dots in filename (e.g.,
release-v1.25.0.md) had incorrect edit URLs. Astro'sentry.idremoves dots for URL safety, so we now extract the original filename fromentry.filePathinstead.Manual Testing Instructions
Click "Edit this page" in https://pr-528.ddev-com-fork-previews.pages.dev/blog/release-v1250/
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes