feat(warnings): Allow silencing warnings about custom config files, for #7638#7660
Merged
Conversation
|
Download the artifacts for this pull request:
See Testing a PR.
|
rfay
force-pushed
the
20250925_rfay_silence_warnings
branch
from
a07a9ad to
faddd56
Compare
stasadev
reviewed
Sep 26, 2025
Comment on lines
+732
to
+736
| if len(unexpected) > 0 { | ||
| printable, _ := util.ArrayToReadableOutput(unexpected) | ||
| util.Warning("Unexpected files found in .ddev/traefik/config (expected only %s): %v", app.Name+".yaml", printable) | ||
| customConfig = true | ||
| } |
Member
There was a problem hiding this comment.
Should people be able to silence this too?
rfay
force-pushed
the
20250925_rfay_silence_warnings
branch
from
faddd56 to
c392420
Compare
stasadev
reviewed
Sep 29, 2025
Member
stasadev
left a comment
stasadev
left a comment
There was a problem hiding this comment.
Let's do the same for the .ddev/.gitignore file:
$ echo '#ddev-silent-no-warn' > .ddev/.gitignore
$ ddev start
Starting l12...
User-managed /home/stas/code/ddev/l12/.ddev/.gitignore will not be managed/overwritten by ddev
...
Member
Author
|
.ddev/.gitignore is so much a part of DDEV's functionality that I'm hesitant to do it, but tell me your thinking. |
stasadev
approved these changes
Sep 30, 2025
Member
stasadev
left a comment
stasadev
left a comment
There was a problem hiding this comment.
.ddev/.gitignore is so much a part of DDEV's functionality that I'm hesitant to do it, but tell me your thinking.
Okay, I agree that this file is a bit different and no modification is expected here.
rfay
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
It's good that we warn people about overridden or extra configuration. But when it's intentional and planned, it becomes just a wall of text hiding other things that might be important.
I have a
~/.ddev/traefik/static-config.loglevel.yamlso every project I start gets a wall of text.Also addresses #7638 by showing a warning in this situation.
How This PR Solves The Issue
#ddev-silent-no-warnto be added to extra config or overridden config, silence the ddev start wall.<project>.yamlsince they're almost always a problem.Manual Testing Instructions
#ddev-silent-no-warn.ddev/traefik/configwarningAutomated Testing Overview
Release/Deployment Notes