Skip to content

feat(test-ddev): add more distro info and default shell to ddev debug test#7666

Merged
rfay merged 5 commits into
ddev:mainfrom
rfay:20250926_rfay_test_show_distro
Sep 30, 2025
Merged

feat(test-ddev): add more distro info and default shell to ddev debug test#7666
rfay merged 5 commits into
ddev:mainfrom
rfay:20250926_rfay_test_show_distro

Conversation

@rfay
Copy link
Copy Markdown
Member

@rfay rfay commented Sep 26, 2025

The Issue

Sometimes we want a little more info on linux especially the distro.
Related: #7664

How This PR Solves The Issue

  • Add Linux distro, default shell
  • Make sure all functions are at the top
  • Put ddev version and ddev debug configyaml output first, it's usually what we want to know about

Manual Testing Instructions

ddev debug test on a few environments

Automated tests

  • Updated TestCmdDebugTest to look for this change

Assisted by ChatGPT

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 26, 2025

@rfay
Copy link
Copy Markdown
Member Author

rfay commented Sep 26, 2025

ddev-debug-test.txt

Comment thread cmd/ddev/cmd/scripts/test_ddev.sh Outdated
@rfay rfay requested a review from stasadev September 29, 2025 12:58
@rfay rfay marked this pull request as ready for review September 29, 2025 12:58
@rfay rfay requested a review from a team as a code owner September 29, 2025 12:58
Copy link
Copy Markdown
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I have a suggestion to pull our utility image.

echo
header "DDEV version"
DDEV_DEBUG=true ddev version
docker_platform=$(ddev version -j | docker run -i --rm ddev/ddev-utilities jq -r '.raw."docker-platform"' 2>/dev/null)
Copy link
Copy Markdown
Member

@stasadev stasadev Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's always pull ddev/ddev-utilities in ddev debug test to avoid some weird situations:

Edit:

I think it's better to use this:

docker pull ddev/ddev-utilities

(docker run --pull=always may break docker_platform variable on pull error.)

Comment thread cmd/ddev/cmd/scripts/test_ddev.sh
@rfay rfay force-pushed the 20250926_rfay_test_show_distro branch from 927f781 to e722766 Compare September 30, 2025 16:43
@rfay rfay merged commit ad91dcb into ddev:main Sep 30, 2025
7 of 9 checks passed
@rfay rfay deleted the 20250926_rfay_test_show_distro branch September 30, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants