Conversation
…t install latest rootless
|
Download the artifacts for this pull request:
See Testing a PR. |
ddev start for docker-rootless w/o no-bind-mount, don't test with latest rootlessddev start for docker-rootless w/o no-bind-mounts, don't test with latest rootless
|
Thanks for exploring this! |
rfay
left a comment
There was a problem hiding this comment.
It seems fine, there's just the question of whether we should keep up with upstream releases.
| curl -fsSL https://get.docker.com/rootless -o /tmp/docker-rootless-install.sh | ||
| # Get Docker version from docker --version (format: "Docker version 29.1.3, build f52814d454") | ||
| DOCKER_VERSION=$(docker --version | sed -E 's/Docker version ([0-9]+\.[0-9]+\.[0-9]+).*/\1/') | ||
| # Replace STABLE_LATEST with the current Docker version to match rootful installation |
There was a problem hiding this comment.
A lot of times we profit from not wiring the specific versions of things, so we find out early when things go wrong. I know you know that. It also would be nice to not have this fail intermittently, and of course it may be a result of the current version we're getting.
There was a problem hiding this comment.
We don't test against the latest Docker rootful. GitHub Actions comes with a preinstalled Docker version (28.0.4 on Ubuntu 24.04), and we don't update it, so in practice we are already wired to a specific Docker version. This change just aligns our setup with what we already use.
I'm not sure whether this change actually helps with Docker rootless. One successful test doesn't say much. I'd like to see how it behaves after being in the main branch for a while. If it doesn't help, then we can think about a different strategy.
The Issue
We see intermittent fails for docker builds in
docker-rootlesshttps://github.com/ddev/ddev/actions/runs/20281804435/job/58245516314
https://github.com/ddev/ddev/actions/runs/20283152764/job/58265709576
It always installs the latest version:
When Rootless was merged:
Also, Docker Rootless does not work without
no-bind-mounts, but I didn't add a check for this because I was thinking about a flexible configuration, but our users will not read the setup instructions very carefully, and we will get support requests why it does not work:How This PR Solves The Issue
ddev startifno-bind-mountsis not enabled.Manual Testing Instructions
Check
docker-rootlesstest in GitHub Actions, confirm the installed docker version is not the latest 29.1.3 https://github.com/ddev/ddev/actions/runs/20302539723/job/58311490118?pr=7952#step:8:165Automated Testing Overview
Release/Deployment Notes