feat: add aggregate_gc_threshold of 0 to drupal12 settings.ddev.php (#8215) [skip ci]#8215
Merged
Merged
Conversation
|
Download the artifacts for this pull request:
See Testing a PR.
|
rfay
approved these changes
Mar 10, 2026
Member
rfay
left a comment
rfay
left a comment
There was a problem hiding this comment.
The only thing really required here is consensus in Drupal folk that this is the right setting for local dev.
| // https://www.drupal.org/forum/support/post-installation/2018-07-18/enable-drupal-8-backend-errorlogdebugging-mode | ||
| $config['system.logging']['error_level'] = 'verbose'; | ||
|
|
||
| // Omit to retain asset aggregates |
Member
There was a problem hiding this comment.
The comment is a bit misleading; people shouldn't be editing this file. Having a reference to the issue is fine.
rfay
force-pushed
the
20260310-rpkoller-asset-aggregates-d12
branch
from
92e67ad to
c5ba18a
Compare
Member
|
I'll go ahead and pull this @rpkoller but if you can make sure that some of your colleagues agree that it belongs in local dev by default it will be much appreciated. |
rfay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
Set the newly introduced aggregate_gc_threshold to 0 (https://www.drupal.org/project/drupal/issues/3505776) in settings.ddev.php for drupal12
the comment describing the newly added setting could be improved i suppose
How This PR Solves The Issue
Manual Testing Instructions
Automated Testing Overview
Release/Deployment Notes