Skip to content

docs: document Mailpit plus-address auto-tagging and how to disable it (#8222) [skip ci]#8222

Merged
rfay merged 4 commits into
ddev:mainfrom
maks-oleksyuk:chore/disable-plus-addresses-tags-in-mailpit
Mar 27, 2026
Merged

docs: document Mailpit plus-address auto-tagging and how to disable it (#8222) [skip ci]#8222
rfay merged 4 commits into
ddev:mainfrom
maks-oleksyuk:chore/disable-plus-addresses-tags-in-mailpit

Conversation

@maks-oleksyuk
Copy link
Copy Markdown
Contributor

@maks-oleksyuk maks-oleksyuk commented Mar 12, 2026

Adds documentation explaining Mailpit's auto-tagging behavior and provides instructions on how to disable it using the MP_TAGS_DISABLE=plus-addresses environment variable.

Includes both global and per-project configuration examples.

Manual Testing Instructions

Automated Testing Overview

No automated tests were added, as this PR only updates documentation.

Release/Deployment Notes

No impact on runtime behavior. Documentation-only change.

@maks-oleksyuk maks-oleksyuk requested a review from a team as a code owner March 12, 2026 11:13
@github-actions
Copy link
Copy Markdown

@rfay
Copy link
Copy Markdown
Member

rfay commented Mar 12, 2026

Hi @maks-oleksyuk - Can you say more about why this is important to you, and why change DDEV itself instead if just doing

web_environment:
   - MP_TAGS_DISABLE=plus-addresses

in your affected project?

@maks-oleksyuk
Copy link
Copy Markdown
Contributor Author

@rfay, during testing, it looks like this, and it's a little confusing what these tags are and where they come from. I turned it off for me using the env variable as you wrote, but I think this fix will also help prevent cases like mine.

image

@rfay
Copy link
Copy Markdown
Member

rfay commented Mar 12, 2026

But, since it's changing the default behavior, it might also adversely affect somebody else.

@rfay
Copy link
Copy Markdown
Member

rfay commented Mar 12, 2026

Super interesting!

@maks-oleksyuk
Copy link
Copy Markdown
Contributor Author

Well, I don't think it will have much of an impact on anyone. On the contrary, at first I didn't understand where these tags came from and what I was doing wrong (since I was testing notifications)

And this is very non-obvious behavior when creating tags, and it doesn't affect the content of the letter itself or anything else

@penyaskito
Copy link
Copy Markdown
Member

Agree with @rfay that changing the default settings of Mailpit might be even more confusing for other users.
But maybe this could be a very simple ddev add-on instead?

Copy link
Copy Markdown
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, it can be set globally in the global user's config for all projects ($HOME/.ddev/global_config.yaml), if those tags are distracting:

ddev config global --web-environment-add=MP_TAGS_DISABLE=plus-addresses

I'm not sure about disabling this feature for everyone, since some people may benefit from it.

@stasadev
Copy link
Copy Markdown
Member

stasadev commented Mar 23, 2026

@maks-oleksyuk,

What do you think about turning this PR into a docs PR?

You could update https://docs.ddev.com/en/stable/users/usage/developer-tools/#email-capture-and-review-mailpit and add the example I gave above about how to control this behavior globally.

See https://github.com/ddev/ddev/blob/main/docs/content/users/usage/developer-tools.md?plain=1#L126

@maks-oleksyuk
Copy link
Copy Markdown
Contributor Author

@stasadev, okay, that's a good idea. I'll update it when I get a chance, but for now I'll mark it as a draft
Thanks for the advice on the global configuration; it's really helpful for me

@maks-oleksyuk maks-oleksyuk marked this pull request as draft March 23, 2026 19:24
@maks-oleksyuk maks-oleksyuk marked this pull request as ready for review March 24, 2026 18:21
@maks-oleksyuk maks-oleksyuk requested a review from a team as a code owner March 24, 2026 18:21
@rfay
Copy link
Copy Markdown
Member

rfay commented Mar 27, 2026

Thanks for the contribution. A little note for the docs in a future PR will be welcome. Closing this for now.

@rfay rfay closed this Mar 27, 2026
@maks-oleksyuk
Copy link
Copy Markdown
Contributor Author

@rfay, why was it closed? I added a commit that includes a note in the documentation—did I do something wrong?

@stasadev
Copy link
Copy Markdown
Member

@maks-oleksyuk, could you update the title and the first post to follow our template.

Right now, they don't reflect what was done here.

@stasadev stasadev reopened this Mar 27, 2026
@rfay
Copy link
Copy Markdown
Member

rfay commented Mar 27, 2026

I expected you to open a new PR with appropriate information, since the target changed.

@maks-oleksyuk maks-oleksyuk changed the title chore: disable plus-addresses tags in Mailpit docs: document Mailpit plus-address auto-tagging and how to disable it Mar 27, 2026
@stasadev stasadev force-pushed the chore/disable-plus-addresses-tags-in-mailpit branch from e10ac0c to d103bad Compare March 27, 2026 11:44
Copy link
Copy Markdown
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks.

@rfay rfay changed the title docs: document Mailpit plus-address auto-tagging and how to disable it docs: document Mailpit plus-address auto-tagging and how to disable it (#8222) [skip ci] Mar 27, 2026
@rfay rfay merged commit 60ea9a7 into ddev:main Mar 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants