Add download and upload functionality #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehart2001
approved these changes
Nov 6, 2025
Collaborator
joehart2001
left a comment
joehart2001
left a comment
There was a problem hiding this comment.
nice idea to keep the github download functionality as well as the s3 bucket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
Adds options to upload and download data from S3 storage, and replaces current data stored in https://github.com/joehart2001/mlipx with data in this storage.
I've generalised the download from a GitHub repository too, although this is now unused, as it may be used by external contributors.
Linked issue
Resolves #39.
Some of the input data may be moved to http://data-collections.psdi.ac.uk/, but we finalise the API, and a lot of this data isn't owned by us.
Testing
Tested all current benchmarks, and tested uploading data (used in the benchmarks as this is then downloaded again)