Skip to content

Fix S3 download via Python#283

Merged
joehart2001 merged 2 commits intoddmms:mainfrom
ElliottKasoar:fix-download
Jan 26, 2026
Merged

Fix S3 download via Python#283
joehart2001 merged 2 commits intoddmms:mainfrom
ElliottKasoar:fix-download

Conversation

@ElliottKasoar
Copy link
Collaborator

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

Summary

Fixes bug downloading data from S3, when the filename passed to tqdm is a Path.

Testing

Tested locally for ml_peg download and via download_s3_data.

@ElliottKasoar ElliottKasoar added the bug Something isn't working label Jan 26, 2026
@ElliottKasoar ElliottKasoar changed the title Fix download Fix S3 download Jan 26, 2026
@ElliottKasoar ElliottKasoar changed the title Fix S3 download Fix S3 download via Python Jan 26, 2026
Copy link
Collaborator

@joehart2001 joehart2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now

@joehart2001 joehart2001 merged commit 3e4356a into ddmms:main Jan 26, 2026
7 checks passed
@ElliottKasoar ElliottKasoar deleted the fix-download branch January 26, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants