Float64 precision for static tests#408
Merged
joehart2001 merged 4 commits intoddmms:mainfrom Mar 5, 2026
Merged
Conversation
ElliottKasoar
force-pushed
the
float_precision
branch
from
a6aa1ab to
57e8ab4
Compare
ElliottKasoar
previously approved these changes
Mar 5, 2026
joehart2001
reviewed
Mar 5, 2026
Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
joehart2001
approved these changes
Mar 5, 2026
kuryla
added a commit
to kuryla/ml-peg-omol
that referenced
this pull request
Mar 12, 2026
Co-authored-by: Domantas Kuryla <dk584@icepc16> Co-authored-by: ElliottKasoar <45317199+ElliottKasoar@users.noreply.github.com> Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
For tests involving static calculations and geometry optimizations, float64 precision is used. This is to fix the noisy energy numbers that some models (such as mace-polar-1) give with float32.
Linked issue
Resolves #
Testing
Evaluated modified tests with MACE-OMOL