fix initial metric weight propagation to the overall summary table#447
Merged
ElliottKasoar merged 3 commits intomainfrom Apr 7, 2026
Merged
fix initial metric weight propagation to the overall summary table#447ElliottKasoar merged 3 commits intomainfrom
ElliottKasoar merged 3 commits intomainfrom
Conversation
Collaborator
ElliottKasoar
left a comment
There was a problem hiding this comment.
For my future reference since it took me a second to follow the problem, we just need to set the weights before we calculate the score when we're building the tables during analysis.
The weights are saved either way, but currently the initial score saved to JSON is unweighted, so the weight is only applied when we visit the tab.
Good catch, @joehart2001!
ElliottKasoar
approved these changes
Apr 7, 2026
JonathanSchmidt1
pushed a commit
to JonathanSchmidt1/ml-peg
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
Issue: for e.g. supramolecular complexes score, the score shown in the overall summary table was the score with weights of 1 applied for all benchmark metrics. this score updates to the correct score once we go onto the category tab and back, but of course we want to see the correct weighted score initially.
decorators.py: build default metric weights before the initial calc_table_scores call, so the saved json starts with the correct weighted scoreLinked issue
Resolves #
Testing