Skip to content

fix initial metric weight propagation to the overall summary table#447

Merged
ElliottKasoar merged 3 commits intomainfrom
propagation-fix
Apr 7, 2026
Merged

fix initial metric weight propagation to the overall summary table#447
ElliottKasoar merged 3 commits intomainfrom
propagation-fix

Conversation

@joehart2001
Copy link
Copy Markdown
Collaborator

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

Summary

Issue: for e.g. supramolecular complexes score, the score shown in the overall summary table was the score with weights of 1 applied for all benchmark metrics. this score updates to the correct score once we go onto the category tab and back, but of course we want to see the correct weighted score initially.

decorators.py: build default metric weights before the initial calc_table_scores call, so the saved json starts with the correct weighted score

Linked issue

Resolves #

Testing

Copy link
Copy Markdown
Collaborator

@ElliottKasoar ElliottKasoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my future reference since it took me a second to follow the problem, we just need to set the weights before we calculate the score when we're building the tables during analysis.

The weights are saved either way, but currently the initial score saved to JSON is unweighted, so the weight is only applied when we visit the tab.

Good catch, @joehart2001!

@ElliottKasoar ElliottKasoar added the bug Something isn't working label Apr 7, 2026
@ElliottKasoar ElliottKasoar merged commit 547013d into main Apr 7, 2026
14 checks passed
@ElliottKasoar ElliottKasoar deleted the propagation-fix branch April 7, 2026 14:05
JonathanSchmidt1 pushed a commit to JonathanSchmidt1/ml-peg that referenced this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants