Skip to content

Phonon calc + structure visualisaiton#555

Merged
ElliottKasoar merged 30 commits into
mainfrom
phonon-calc
May 22, 2026
Merged

Phonon calc + structure visualisaiton#555
ElliottKasoar merged 30 commits into
mainfrom
phonon-calc

Conversation

@joehart2001
Copy link
Copy Markdown
Collaborator

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

Summary

Added phonon calc + DFT and MLIP relaxed structure visualisation

Also, about a 1.5x speedup in the calculation time which is nice

Linked issue

Resolves #

Testing

running all models now, matches results for mp-0a so far

@joehart2001 joehart2001 requested a review from ElliottKasoar May 19, 2026 14:37
@joehart2001 joehart2001 marked this pull request as ready for review May 19, 2026 14:37
Copy link
Copy Markdown
Collaborator

@ElliottKasoar ElliottKasoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great! I need to test it more carefully, but I've left some minor comments for now

Comment thread ml_peg/calcs/bulk_crystal/phonons/phonons_utils.py Outdated
Comment thread ml_peg/calcs/bulk_crystal/phonons/phonons_utils.py Outdated
Comment thread ml_peg/calcs/bulk_crystal/phonons/phonons_utils.py
Comment thread ml_peg/app/utils/build_callbacks.py Outdated
Comment thread ml_peg/app/utils/build_callbacks.py Outdated
Comment thread ml_peg/calcs/bulk_crystal/phonons/calc_phonons.py
@ElliottKasoar ElliottKasoar added enhancement New feature or request new benchmark Proposals and suggestions for new benchmarks labels May 20, 2026
@ElliottKasoar
Copy link
Copy Markdown
Collaborator

What's the main source of speedup out of interest?

@joehart2001
Copy link
Copy Markdown
Collaborator Author

What's the main source of speedup out of interest?

mutliple small factors:

  • changed 3/6 of the ref outputs (qpoints, labels and connectiosn files) to one pkl file
  • probably mlipx node overhead
  • threadpool_limits
  • yaml loading: CSafeLoader is the C-extension binding to libyaml which can apparently be 10-50x faster

ElliottKasoar
ElliottKasoar previously approved these changes May 22, 2026
Copy link
Copy Markdown
Collaborator

@ElliottKasoar ElliottKasoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great from testing!

One small thing is that the scatter plot resizes when you open the second plot, which is a bit odd, but it's a lot better than it was.

Copy link
Copy Markdown
Collaborator

@ElliottKasoar ElliottKasoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ElliottKasoar ElliottKasoar merged commit df4d67b into main May 22, 2026
14 checks passed
@ElliottKasoar ElliottKasoar deleted the phonon-calc branch May 22, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request new benchmark Proposals and suggestions for new benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants