features review and validation

Review and validation

Active contributors: ddv1982

Purpose

Review and validation are evidence inputs to completion. skills/flow-test/SKILL.md selects and summarizes checks, skills/flow-review/SKILL.md returns review payloads, and src/runtime/transitions.ts refuses completion until the accepted evidence is present and passing.

Directory layout

skills/
├── flow-test/SKILL.md
├── flow-review/SKILL.md
├── flow-review/references/review-rubric.md
└── flow-run/references/validation-rubric.md
src/runtime/
├── schema.ts
└── transitions.ts

Key abstractions

Abstraction	File	Description
ValidationRunSchema	src/runtime/schema.ts	Command/status/summary validation evidence.
ValidationScopeSchema	src/runtime/schema.ts	targeted or broad.
ReviewSchema	src/runtime/schema.ts	Feature review payload.
FinalReviewSchema	src/runtime/schema.ts	Final review payload with reviewDepth.
validateCompletion	src/runtime/transitions.ts	Enforces evidence and review gates.

How it works

Feature completion requires at least one passing validation run, validationScope: "targeted" for non-final features, and a passing featureReview with no blocking findings. Final feature completion requires validationScope: "broad", a passing featureReview, a passing finalReview, and finalReview.reviewDepth equal to the plan's finalReviewPolicy.

Integration points

The review feature connects skills and runtime without giving review its own state-changing tool. skills/flow-review/SKILL.md returns payloads, and the manager records them in flow_feature_complete through src/runtime/api.ts. tests/runtime-gates.test.ts verifies rejected missing, failed, or mismatched evidence.

Key source files

File	Purpose
skills/flow-test/SKILL.md	Validation selection, run discipline, and evidence output shape.
skills/flow-review/SKILL.md	Feature and final review procedure.
src/runtime/schema.ts	Validation and review schemas.
src/runtime/transitions.ts	Completion evidence gate.
tests/runtime-gates.test.ts	Review and validation enforcement tests.

Entry points for modification

Change validation judgment in skills/flow-test/SKILL.md or review judgment in skills/flow-review/SKILL.md. Change src/runtime/schema.ts and src/runtime/transitions.ts only when the hard evidence contract changes.

Related pages: Execution and completion, Validation and review primitive, and Testing.