Skip to content

fix: stop firing interrupt on local transcription (race condition)#372

Merged
osimhi213 merged 1 commit intomainfrom
chore/remove-on-interrupt-detected-callback
Apr 28, 2026
Merged

fix: stop firing interrupt on local transcription (race condition)#372
osimhi213 merged 1 commit intomainfrom
chore/remove-on-interrupt-detected-callback

Conversation

@osimhi213
Copy link
Copy Markdown
Contributor

@osimhi213 osimhi213 commented Apr 28, 2026

Summary

  • Removes the internal onInterruptDetected wiring that fired on local-participant transcription while the agent was Talking
  • This was racy: the transcription-driven interrupt could cancel an in-flight request the user did not actually mean to interrupt
  • Public interrupt() API on the agent manager is unchanged — explicit interrupts still work as before
  • Also drops the now-unused Interrupt import and a stale JSDoc comment, and updates livekit-manager.test.ts to remove the corresponding mock/assertions

References

Test plan

  • npm test — Transcription Interrupt Detection suite still passes (latency tracker still updates; no interrupt is dispatched)
  • Type-check passes
  • Smoke-test a live agent session: local user speaking during Talking state no longer cancels the active request via the transcription path

🤖 Generated with Claude Code

Drops the internal onInterruptDetected wiring between the streaming
manager and agent manager. The public interrupt() API on the agent
manager remains unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@osimhi213 osimhi213 requested a review from ReutAtias3 April 28, 2026 11:46
@osimhi213 osimhi213 changed the title chore: remove unused onInterruptDetected callback fix: stop firing interrupt on local transcription (race condition) Apr 28, 2026
@osimhi213 osimhi213 merged commit 808ca6b into main Apr 28, 2026
9 checks passed
@osimhi213 osimhi213 deleted the chore/remove-on-interrupt-detected-callback branch April 28, 2026 11:56
@osimhi213 osimhi213 mentioned this pull request Apr 28, 2026
osimhi213 added a commit that referenced this pull request Apr 28, 2026
…-callback (#374)

fix: stop firing interrupt on local transcription (race condition)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants