Docker build files and tweaks#35
Conversation
hassayag
left a comment
There was a problem hiding this comment.
This is excellent, I've left some thoughts on keeping output-data and decompiled-data separate, let me know what you think.
Running the code locally unfortunately is not working, as it fails at the parsing stage. Does it fully work for you when you run main.sh?
|
I've also invited you to the org, so future work can be on the main repo |
|
Thank you for the review and invite! I'll start working on those fixes! |
|
Of course! So my goal with the docker container is to make it simpler to deploy and update the output data. Down the line, I think it would be nice to add releases and tag each version of the game data to make it easier to compare changes over time For the windows issue, are you running it on WSL? |
That would be awesome! For tracking changes, the s3.py file uploads it to an s3 bucket, could you join the deadlock community discord and join the #wiki channel? We can link up there! |
Ah so its a way of having a consistent environment for handling the game files locally, I get you now
Big fan of this!
I am yeah. How about we link up on discord and I can show you what errors I get. username - |
This reverts commit c65f701.
There was a problem hiding this comment.
Got it going now, but I am getting some weirdness with the paths. Eg. this is the only error I get cp: cannot create regular file '../../output-data/version.txt': No such file or directory
I think I'd like to just merge it and resolve this separately, as maybe moving decompile.sh will simplify the path issues
Moved target branch to a new develop branch so we can keep master stable
In any case, what a bold first PR, good stuff 🔥
|
Ahh, I like the separate branch! |
I'd appreciate a squash before merging!
Changes:
OUTPUT_DIRenv var to a higher level, and made sure it's respected everywhereOUTPUT_DIR, including thedecompiler_data. Still cleanup afterward, just from the main.sh scriptversion.txtfile to the output data for reference. (usefule for automation?)kv3_to_json.pyto take the output file as a second parameter instead of calculating itos.path.join(a,b)scattered everywhereTested with: