Modifying to use rounding direction in RoundedDecimalField. #16
Conversation
1 similar comment
drf_braces/fields/custom.py
Outdated
| def to_internal_value(self, data): | ||
| return self.quantize(super(RoundedDecimalField, self).to_internal_value(data)) | ||
| def quantize(self, value): | ||
| if self.max_digits is None and isinstance(value, float): |
There was a problem hiding this comment.
this is no longer a DecimalField if it will return float in some cases. it must return float in all cases unless its not required field and value is not provided
| ) | ||
|
|
||
| def to_internal_value(self, data): | ||
| return self.quantize(super(RoundedDecimalField, self).to_internal_value(data)) |
There was a problem hiding this comment.
older versions of DRF dont always call quantize on validation https://github.com/encode/django-rest-framework/blob/3.2.5/rest_framework/fields.py#L935
mmarta
changed the title
drf_braces/fields/custom.py
Outdated
| return data | ||
|
|
||
|
|
||
| class RoundedDecimalField(fields.DecimalField): |
There was a problem hiding this comment.
this is duplicating the class definition
There was a problem hiding this comment.
Apologies, I think this happened when I merged or something.
drf_braces/fields/custom.py
Outdated
| Currency field subclass of Decimal used for rounding currencies | ||
| to two decimal places. | ||
| """ | ||
| rounding = None |
There was a problem hiding this comment.
not necessary as its redefined in `init
drf_braces/fields/custom.py
Outdated
| rounding = None | ||
|
|
||
| def __init__(self, max_digits=None, decimal_places=2, rounding=None, *args, **kwargs): | ||
| max_digits = max_digits or self.MAX_STRING_LENGTH |
There was a problem hiding this comment.
can be safely removed as quantize does not add the context.prec when max digits is None. it was to prevent exceptions with older versions of DRF
2 similar comments
| def test_init(self): | ||
| field = RoundedDecimalField() | ||
| self.assertIsNotNone(field.max_digits) | ||
| self.assertEqual(field.decimal_places, 2) |
There was a problem hiding this comment.
can we add assert about rounding being set
3 similar comments
3 participants
This will now use rounding direction in RoundedDecimalField if specified.