Skip to content

Fix /Contents to mismatch /ByteRange#116

Merged
dealfonso merged 1 commit intodealfonso:mainfrom
erikn69:patch-18
Dec 4, 2025
Merged

Fix /Contents to mismatch /ByteRange#116
dealfonso merged 1 commit intodealfonso:mainfrom
erikn69:patch-18

Conversation

@erikn69
Copy link
Copy Markdown
Contributor

@erikn69 erikn69 commented Oct 13, 2025

@erikn69 erikn69 force-pushed the patch-18 branch 2 times, most recently from ecbe171 to 65224e6 Compare October 13, 2025 17:33
@ssw1cblarrion
Copy link
Copy Markdown

@dealfonso hi, please make a release of this, thanks

@dealfonso
Copy link
Copy Markdown
Owner

I am not sure that this will be merged... I'll include these suggestions on a new work

@ssw1cblarrion
Copy link
Copy Markdown

ssw1cblarrion commented Oct 14, 2025

Will the new job take a long time? Because this seems to work for now.

and also if the new work presents problems it is good to be able to go back to a previous working version(on composer json) until the fix

@angeljqv
Copy link
Copy Markdown

angeljqv commented Dec 4, 2025

@dealfonso hi, please release this, it works
thanks

@dealfonso
Copy link
Copy Markdown
Owner

While this is working, it is a bad practice to do things as they are done in this code; this is the main reason to refactor the code. In this code, we are modifying a class property, but these values are only relevant to the current case.

I am accepting this change, because it seems to be needed now, and in this version is done in this way, but I want to avoid this kind of changes.

@dealfonso dealfonso merged commit cf72a2f into dealfonso:main Dec 4, 2025
@dealfonso
Copy link
Copy Markdown
Owner

@angeljqv please try the main branch

@angeljqv
Copy link
Copy Markdown

angeljqv commented Dec 4, 2025

Thank you

it seems to be needed now, and in this version is done in this way, but I want to avoid this kind of changes

It sounds great, but for now the important thing is that it doesn't give unexpected errors when it seems to be working correctly most of the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using TSA causes a extra xref size

6 participants