Fix /Contents to mismatch /ByteRange#116
Conversation
erikn69
commented
Oct 13, 2025
- Discussed in https://github.com/dealfonso/sapp/pull/75/files#r2426788837
- Closes Using TSA causes a extra xref size #77
ecbe171 to
65224e6
Compare
|
@dealfonso hi, please make a release of this, thanks |
|
I am not sure that this will be merged... I'll include these suggestions on a new work |
|
Will the new job take a long time? Because this seems to work for now. and also if the new work presents problems it is good to be able to go back to a previous working version(on composer json) until the fix |
|
@dealfonso hi, please release this, it works |
|
While this is working, it is a bad practice to do things as they are done in this code; this is the main reason to refactor the code. In this code, we are modifying a class property, but these values are only relevant to the current case. I am accepting this change, because it seems to be needed now, and in this version is done in this way, but I want to avoid this kind of changes. |
|
@angeljqv please try the main branch |
|
Thank you
It sounds great, but for now the important thing is that it doesn't give unexpected errors when it seems to be working correctly most of the time. |