fix: consistency audit batch — H2, M3, M7 from #142#148
Merged
Conversation
added 2 commits
March 18, 2026 21:18
- H2: ambient-router description updated to standard "This skill should be used when..." format - M3: simplifier agent gains Output and Boundaries sections matching scrutinizer pattern - M7: add homepage/repository/license/keywords metadata to 3 plugin.json files (ambient, audit-claude, self-review) Closes remaining HIGH and MEDIUM findings. M1 (acceptable), M4 and M6 (by-design) closed without code changes. H3/H4/H6/M2/M5/M8 were already fixed in PRs #145-147. Refs #142
…L2, L3) - L2: Update CLAUDE.md to acknowledge intentional allowed-tools exceptions (git skills need Bash, interactive skills need AskUserQuestion, persistence skills need Write) - L3: Sync plugin descriptions across all 3 sources (plugin.json, plugins.ts, marketplace.json) using plugin.json as canonical source. 9 plugins had divergent descriptions with missing details. Refs #142
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all HIGH, MEDIUM, and 2 of 3 LOW findings from #142 (post-Wave 2 consistency audit). Only L1 (skill line counts) remains — skipped by design.
Commit 1: H2, M3, M7 code fixes
ambient-routerSKILL.md description updated to standard"This skill should be used when..."formatsimplifier.mdagent gains## Outputand## Boundariessections (matching scrutinizer pattern)homepage,repository,license,keywordsto 3 plugin.json files (devflow-ambient,devflow-audit-claude,devflow-self-review)Commit 2: L2, L3 documentation and description sync
allowed-toolsexceptions (git skills addBash, interactive skills addAskUserQuestion, persistence skills addWrite)plugin.jsonas canonical →plugins.ts+marketplace.json). 9 plugins had divergent descriptions with missing details.Also resolved in issue (no code changes needed)
agents: []is correct;claude-md-auditoris plugin-specific, not sharedPreviously fixed (PRs #145-147)
H3, H4, H6, M2, M5, M8
Remaining (skipped)
references/directoriesTest plan
npm run build— 45 skill copies + 21 agent copies, no errorsnpm test— 250 tests passCloses #142