Skip to content

fix: consistency audit batch — H2, M3, M7 from #142#148

Merged
dean0x merged 2 commits intomainfrom
fix/issue-142-consistency-batch
Mar 18, 2026
Merged

fix: consistency audit batch — H2, M3, M7 from #142#148
dean0x merged 2 commits intomainfrom
fix/issue-142-consistency-batch

Conversation

@dean0x
Copy link
Owner

@dean0x dean0x commented Mar 18, 2026

Summary

Fixes all HIGH, MEDIUM, and 2 of 3 LOW findings from #142 (post-Wave 2 consistency audit). Only L1 (skill line counts) remains — skipped by design.

Commit 1: H2, M3, M7 code fixes

  • H2: ambient-router SKILL.md description updated to standard "This skill should be used when..." format
  • M3: simplifier.md agent gains ## Output and ## Boundaries sections (matching scrutinizer pattern)
  • M7: Added homepage, repository, license, keywords to 3 plugin.json files (devflow-ambient, devflow-audit-claude, devflow-self-review)

Commit 2: L2, L3 documentation and description sync

  • L2: Updated CLAUDE.md to document intentional allowed-tools exceptions (git skills add Bash, interactive skills add AskUserQuestion, persistence skills add Write)
  • L3: Synced plugin descriptions across all 3 sources (plugin.json as canonical → plugins.ts + marketplace.json). 9 plugins had divergent descriptions with missing details.

Also resolved in issue (no code changes needed)

  • M1: Closed as acceptable — agents under 350-line threshold
  • M4: Closed as by-design — specify doesn't load skills, consistent with non-teams variant
  • M6: Closed as by-design — agents: [] is correct; claude-md-auditor is plugin-specific, not shared

Previously fixed (PRs #145-147)

H3, H4, H6, M2, M5, M8

Remaining (skipped)

  • L1: 15 skills exceed 150-line target — acceptable, all have references/ directories

Test plan

  • npm run build — 45 skill copies + 21 agent copies, no errors
  • npm test — 250 tests pass
  • Spot checks: ambient-router description, simplifier sections, plugin.json metadata, description sync

Closes #142

Dean Sharon added 2 commits March 18, 2026 21:18
- H2: ambient-router description updated to standard "This skill should
  be used when..." format
- M3: simplifier agent gains Output and Boundaries sections matching
  scrutinizer pattern
- M7: add homepage/repository/license/keywords metadata to 3 plugin.json
  files (ambient, audit-claude, self-review)

Closes remaining HIGH and MEDIUM findings. M1 (acceptable), M4 and M6
(by-design) closed without code changes. H3/H4/H6/M2/M5/M8 were already
fixed in PRs #145-147.

Refs #142
…L2, L3)

- L2: Update CLAUDE.md to acknowledge intentional allowed-tools
  exceptions (git skills need Bash, interactive skills need
  AskUserQuestion, persistence skills need Write)
- L3: Sync plugin descriptions across all 3 sources (plugin.json,
  plugins.ts, marketplace.json) using plugin.json as canonical source.
  9 plugins had divergent descriptions with missing details.

Refs #142
@dean0x dean0x merged commit 736c3bf into main Mar 18, 2026
3 of 4 checks passed
@dean0x dean0x deleted the fix/issue-142-consistency-batch branch March 18, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Post-Wave 2: Consistency audit findings (32 skills, 17 plugins, 12 commands)

1 participant