Skip to content

Added missing chatbox popups #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riktenx merged 3 commits into from
Mar 30, 2026
Merged

Added missing chatbox popups #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c9b59f
Added missing dialogue ID
Yookiop Mar 30, 2026
72741a0
Members chat popup
Yookiop Mar 30, 2026
1f273af
Text finetune
Yookiop Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.gradle
build
bin/
.idea/
.project
.settings/
Expand Down
17 changes: 16 additions & 1 deletion src/main/java/io/github/deathbeam/plugins/fixedhidechat/FixedHideChatConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,21 @@ public class FixedHideChatConstants
0
);

// Message box dialog (S229.0) - Missing chatbox popup of some NPC's when there's only a "Click here to continue" option.
// This should also fix the missing chatbox popup when buying battlestaves in Varrock (not sure since I tested in F2P).
private static final Map.Entry<Integer, Integer> CHATBOX_MESSAGES_DIALOG_MESSAGEBOX = new AbstractMap.SimpleEntry<>(
net.runelite.api.gameval.InterfaceID.MESSAGEBOX,
0
);

// Membership benefits prompt (S284.0) - "Become a Member" chatbox popup.
private static final Map.Entry<Integer, Integer> CHATBOX_MESSAGES_MEMBERSHIP_PROMPT = new AbstractMap.SimpleEntry<>(
net.runelite.api.gameval.InterfaceID.MEMBERSHIP_BENEFITS_PROMPT,
0
);

// A lot of other stuff, we recurse through this, it should catch any messages under (S162.566 ID: 10617398)
// Wrong PIN popup, Gauntlet Exit Prompt (S229.0 ID: 15007745), NPC Dialog (N231.0 ID: 5138816), Make-X (N270.0 ID: 17694720)... etc.
// Wrong PIN popup, NPC Dialog (N231.0 ID: 5138816), Make-X (N270.0 ID: 17694720)... etc.
private static final Map.Entry<Integer, Integer> CHATBOX_MESSAGES_SPECIAL = new AbstractMap.SimpleEntry<>(
InterfaceID.CHATBOX,
566
Expand Down Expand Up @@ -89,6 +102,8 @@ public class FixedHideChatConstants
.add(CHATBOX_MESSAGES_DIALOG_OPTION)
.add(CHATBOX_MESSAGES_DIALOG_PLAYER)
.add(CHATBOX_MESSAGES_DIALOG_SPRITE)
.add(CHATBOX_MESSAGES_DIALOG_MESSAGEBOX)
.add(CHATBOX_MESSAGES_MEMBERSHIP_PROMPT)
.add(CHATBOX_MESSAGES_SKILLMULTI)
.add(CHATBOX_MESSAGES_CONTAINER)
.add(CHATBOX_MESSAGES_SPECIAL)
Expand Down