updated test#1
Merged
deather merged 3 commits intodeather:test-input-fieldsfrom Sep 15, 2017
storm1er:storm1er/test-input-fields
Merged
updated test#1deather merged 3 commits intodeather:test-input-fieldsfrom storm1er:storm1er/test-input-fields
deather merged 3 commits intodeather:test-input-fieldsfrom
storm1er:storm1er/test-input-fields
Conversation
8 tasks
Owner
|
@storm1er : I think it will be better to set inputBrowser.input.val("") instead of inputBrowser.input.val(inputBrowser.badValue), because it is closest to the reality. Badvalue can be some other stuff, it is depending of the input type. But you are right I miss this case :/ |
Author
|
Hmmm, you're right, editing now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So user input reset is also checked