[FIX] 작은화면 작전시간 타이머 깨짐 해결 #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Applied changes on type.ts to CustomizeTimerPage - Renamed CustomizeTimerPage to TimerPage (because from now CustomizeTimerPage is a default timer)
작전 시간 타임박스가 있음에도 불구하고 작전 시간 버튼이 표시되는 오류 수정
jaeml06
approved these changes
May 23, 2025
Contributor
jaeml06
left a comment
jaeml06
left a comment
There was a problem hiding this comment.
넵 스토리북에서 확인하니 정상으로 변경되는 것 같습니다.
katie424
added a commit
that referenced
this pull request
Jun 1, 2025
* chore: Deleted parliamentary timer * refactor: Deleted parliamentary codes from TableListPage * refactor: Deleted unnecessary debate types from type.ts * refactor: Deleted parliamentary codes from Table of TableListPage * refactor: Removed parliamentary codes from TableOverviewPage * refactor: Removed all interfaces and type converters for parliamentary * refactor: Removed parliamentary codes from TableCompositionPage * refactor: Refactored CustomizeTimerPage - Applied changes on type.ts to CustomizeTimerPage - Renamed CustomizeTimerPage to TimerPage (because from now CustomizeTimerPage is a default timer) * refactor: Disabled parliamentary API mocking * chore: Applied timer name change on routes.tsx * chore: Removed parliamentary API hooks * refactor: Applied changes from type.ts to customize API hooks * chore: Removed primitive parliamentary API codes * refactor: Applied changes from type.ts to primitive customize API codes * refactor: Resolve problems identified from linting * fix: Fixed error that app requests table data on create mode * fix: Fixed timeout button error 작전 시간 타임박스가 있음에도 불구하고 작전 시간 버튼이 표시되는 오류 수정 * refactor: Renamed API functions and response types * fix: Fixed bug that user input doesn't applied on text field * refactor: Typo * chore: Resolved merge conflicts from PR #266 and #270 * fix: 작전시간 타이머 깨짐 수정 --------- Co-authored-by: Shawn Kang <shineksu813@outlook.com> Co-authored-by: Shawn Kang <csm06063@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 연관 이슈
closed #271
📝 작업 내용
🏞️ 스크린샷 (선택)
🗣️ 리뷰 요구사항 (선택)