Skip to content

feat(ui) remove table limits for monaco autosuggestion#130

Merged
debba merged 1 commit intodebba:mainfrom
thomaswasle:feature/remove-limits-for-autosuggestion
Apr 13, 2026
Merged

feat(ui) remove table limits for monaco autosuggestion#130
debba merged 1 commit intodebba:mainfrom
thomaswasle:feature/remove-limits-for-autosuggestion

Conversation

@thomaswasle
Copy link
Copy Markdown
Contributor

This PR removes the number of tables limitations which where implemented in the use of monaco.

I tested with database which have 6000+ tables and there seem to be no significant performance deteriorations.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot bot commented Apr 12, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The PR successfully removes the arbitrary suggestion limits (MAX_TABLE_SUGGESTIONS: 50, MAX_TOTAL_SUGGESTIONS: 200) from Monaco's autocomplete. The code is clean and the tests are appropriately updated.

Changes reviewed:

  • src/utils/autocomplete.ts:258-273 - Now returns all table/keyword suggestions without capping
  • tests/utils/autocomplete.test.ts - Updated assertions to expect full result sets
Files Reviewed (2 files)
  • src/utils/autocomplete.ts
  • tests/utils/autocomplete.test.ts

Reviewed by kimi-k2.5-0127 · 81,659 tokens

@debba
Copy link
Copy Markdown
Owner

debba commented Apr 13, 2026

Looks good to me, thanks @thomaswasle I will merge it

@debba debba merged commit 873f467 into debba:main Apr 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants