Skip to content

Feat mysql ssl#133

Merged
debba merged 2 commits intodebba:mainfrom
traustitj:feat-mysql-ssl
Apr 15, 2026
Merged

Feat mysql ssl#133
debba merged 2 commits intodebba:mainfrom
traustitj:feat-mysql-ssl

Conversation

@traustitj
Copy link
Copy Markdown
Contributor

New MySQL/MariaDB driver and connection pool with support for SSL certificates.
Settings tab for adding certificates for connection.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot bot commented Apr 14, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • src-tauri/src/drivers/mysql/extract.rs - Refactored variable naming, removed debug logging
  • src-tauri/src/models.rs - Added ssl_ca, ssl_cert, ssl_key fields to ConnectionParams
  • src-tauri/src/pool_manager.rs - Implemented MySqlConnectOptions-based connection with SSL support
  • src/components/modals/NewConnectionModal.tsx - Added SSL tab for certificate configuration

Notes

  • The refactoring in extract.rs improves code readability by using descriptive variable names
  • SSL implementation properly maps MySQL SSL modes (disabled/preferred/required/verify_ca/verify_identity)
  • New connection pool functions (get_mysql_pool_for_database_with_id, has_pool_for_database) maintain backward compatibility while enabling per-database pooling
  • UI correctly shows SSL certificate inputs only when SSL mode is not disabled

Reviewed by kimi-k2.5-0127 · 297,219 tokens

@debba
Copy link
Copy Markdown
Owner

debba commented Apr 15, 2026

Looks good to me,
thanks a lot for your contribution.
Hope you will continue use Tabularis and improve it :)

@debba debba merged commit 994eb4e into debba:main Apr 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants