fix(browser): should check whether process exists#325
Closed
tomtomau wants to merge 1 commit intodebug-js:masterfrom
Closed
fix(browser): should check whether process exists#325tomtomau wants to merge 1 commit intodebug-js:masterfrom
tomtomau wants to merge 1 commit intodebug-js:masterfrom
Conversation
Contributor
|
Nice, I just did the same: https://github.com/stephenmathieson/debug/commit/1213eb4f8a77248329526c6feac1f211938acf20 Ref: #324 (comment) |
Contributor
|
Good catch. Let us know if v2.3.2 doesn't fix it for you guys. |
|
Maybe a better idea is to do something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, 2.3.1 breaks in the browser. We need to check whether
processis defined.