fix(browser): do not override ls debug if found#331
Merged
thebigredgeek merged 1 commit intodebug-js:masterfrom Nov 14, 2016
Merged
fix(browser): do not override ls debug if found#331thebigredgeek merged 1 commit intodebug-js:masterfrom
thebigredgeek merged 1 commit intodebug-js:masterfrom
Conversation
Contributor
|
LGTM /cc @thebigredgeek @ibc Fixes #330 I think. |
Contributor
Author
|
I believe so, exactly my issue. I've closed the issue via the description 👍 |
Contributor
Contributor
|
Yeah I'll release this morning once I get to office :) |
thebigredgeek
added
bug
|
@thebigredgeek Any news? 2.3.2 is broken in quite a few cases and a release would be very welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In React apps built with Webpack
process.env.NODE_ENVis set as a global. This meansprocess.envis a global object. The current browser code overrides whatever is found in localStorage. This PR returns early if a debug value is found in localStorage.Fixes #330