Work around debug being loaded in preload scripts#368
Merged
thebigredgeek merged 1 commit intodebug-js:masterfrom Dec 14, 2016
Merged
Work around debug being loaded in preload scripts#368thebigredgeek merged 1 commit intodebug-js:masterfrom
thebigredgeek merged 1 commit intodebug-js:masterfrom
Conversation
Contributor
|
#369 < wondering if this is the same issue? |
Contributor
Author
|
@thebigredgeek Doesn't look like it but might be related? The callstack for us was trying to access |
Contributor
Author
|
@thebigredgeek If you could cut a release off of this we'd be v grateful, this debug issue is causing us a lot of grief over at Slack because we use it in lots of low-level components that aren't easily patched |
Contributor
|
@paulcbetts done :). 2.4.4 now live |
Contributor
Author
|
Thank you so much! |
Contributor
|
Np! Good luck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-on to #324, where if debug is loaded in a preload script (https://github.com/electron/electron/blob/d6e3360aeff6c50820a08af28f1097a0c25d6e3e/docs/api/web-view-tag.md#preload), it will crash in
useColorsbecause the DOM is not fully set-up yet (window.document.documentElementwill be undefined, butwindow.documentexists)