Fixed IE8 "Expected identifier" error#414
Merged
thebigredgeek merged 1 commit intodebug-js:masterfrom Jan 20, 2017
vgoma:export-default-fix
Merged
Fixed IE8 "Expected identifier" error#414thebigredgeek merged 1 commit intodebug-js:masterfrom vgoma:export-default-fix
thebigredgeek merged 1 commit intodebug-js:masterfrom
vgoma:export-default-fix
Conversation
|
This makes the library compatible with IE8 - which is super useful for me. Thanks! |
|
Also looking forward to this fix, any feedback @thebigredgeek? |
Contributor
|
👍 But if you could, just have it be the single line change for the quotes. We have a release process that happens in a separate commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"default" is reserved word in IE8. So it produces 'Expected identifier' error. Fixed that with quotes.