Fix docker image build failure after node:lts-alpine changed to 18. #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 22, 2022 22:23
Base image for building the frontend is referenced with its tag on the Dockerfile (FROM node:lts-alpine). The tag has been recently changed, and now points to version 18 of nodejs. Attempting to build with new lts (v.18), results in an error when building the frontend: > [frontend-build 8/8] RUN yarn build: Adding the ENV var has fixed the build issue, and the container image is now produced without errors.
Owner
|
Hello, @gadamo! Thanks for your PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix image build error. While there, also updated zerotier to latest minor version.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Base image for building the frontend is referenced with its tag on
the Dockerfile (FROM node:lts-alpine). The tag has been recently
changed, and now points to version 18 of nodejs.
Attempting to build with new lts (v.18), results in an error when
building the frontend:
Issue Number: N/A
What is the new behavior?
Adding the ENV var has fixed the build issue, and the container image
is now produced without errors.
Does this introduce a breaking change?