Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Basically, this adds the
packageManagerfield to avoid dependencies being installed usingyarnorpnpm. The way they hoist and symlink packages all have differences, and if you installed the project using something else thannpm(in my case, pnpm) it would lead to an issue when trying to runnpm run build.This is to improve the developer experience especially for first-time contributors, since many expect every repository to work fine nowadays with pnpm, for example. In a follow-up PR, we can definitely change to pnpm as default since it has better monorepo support than npm.
Test plan
If you try to run

yarn installorpnpm installit will be blocked through corepack, e.g.Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)
