Replies: 1 comment
|
@giladger and I settled on the following solution for now:
|
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Problem
When a shot stops, reaprime waits 4s to catch the final drips and update
actualYield.But this is invisible to the user, who usually lifts the cup the instant the shot
stops — corrupting
actualYield. The post-stop "tail" also contains wrongpressure/flow and is normally trimmed by the UI anyway.
Current state (implemented)
trustedFinalYield: weight is latched at the machine-reported stop, thenrefined only by sensible post-stop increases (≤2 g/sample, ≤5 g total,
flow <3 g/s).
actualYieldderives from this, not from scanning the raw trace.Cup removal / touch spikes no longer rewrite the yield.
yield follows the drips — the graph doesn't.
scale drips, so without a scale there's nothing to wait for.
Open questions / proposed changes
yield, which
trustedFinalYieldnow captures independently. Remaining questionis purely whether the wrong-pressure/flow, UI-trimmed tail rows are worth keeping.
under-target and must catch up post-stop. The current gating (flow ≤3 g/s,
<2 g/sample) is tuned for drips, so a fast shot stopped with a large projection
could undershoot. Proposal: anchor the allowed rise to the target (we stopped
because projected ≥ target, so climbing to ~target shouldn't be flow-gated),
apply strict drip/spike gating only beyond it.
All reactions