Skip to content

feat: data query skill improvements#65

Merged
akalautaro merged 1 commit intomainfrom
feat/data-query-improvements
Apr 1, 2026
Merged

feat: data query skill improvements#65
akalautaro merged 1 commit intomainfrom
feat/data-query-improvements

Conversation

@akalautaro
Copy link
Copy Markdown

Summary

Improves the data-query skill based on a structured review of GPT and Gemini feedback — filtering valid suggestions from already-implemented or invalid ones, and migrating data-specific knowledge out of the skill prompt and into the canonical llm-index.

Changes

  • Added interpretation layer: after returning results, Jarvis must add 1–3 sentences explaining the business meaning, trends, or anomalies
  • Added ranking disambiguation rule
  • Simplified channel disambiguation rule
  • Added SQL guardrails: prohibit SELECT * and cartesian joins (no ON clause), also timeout for ad-hoc queries
  • Updated Metabase URL edge case: Jarvis now attempts to resolve the backing dbt model via exposures.yml before falling back to the generic "can't access Metabase" message
  • Removed specific table names from ambiguous questions table (already in llm-index routing table)

Testing

No functional code changes.

@akalautaro akalautaro requested a review from nachomazzara March 31, 2026 22:10
@akalautaro akalautaro self-assigned this Mar 31, 2026
@akalautaro akalautaro changed the title feat: analyst interpretation layer, disambiguation rules, SQL guardra… feat: data query skill improvements Mar 31, 2026
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 23821790852

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 26.227%

Totals Coverage Status
Change from base Build 23812408657: 0.0%
Covered Lines: 236
Relevant Lines: 860

💛 - Coveralls

@akalautaro akalautaro merged commit 7ccf994 into main Apr 1, 2026
7 checks passed
@akalautaro akalautaro deleted the feat/data-query-improvements branch April 1, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants