feat: open desktop explorer via deep-link in see-in-world modal#3412
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Coverage Report for CI Build 26560477565Coverage remained the same at 51.748%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users click Jump In in the See-in-World modal, the builder now tries to launch the desktop client via
decentraland://?self-preview-builder-collections=<id>&dclenv=<env>&position=x,yinstead of opening /play in a new tab. Detection uses focus/visibilityloss within 750ms (consistent with the ui2
launchDesktopApppattern). When the deep link does not resolve, aDownloadModalfromdecentraland-ui2opens linking to decentraland.org/download. The legacygetExplorerURLis untouched so consumers that still need the /play URL keepworking.
Test plan