This repository was archived by the owner on Feb 27, 2023. It is now read-only.
PR review suggestions#334
Merged
Merged
Conversation
menduz
commented
Jun 9, 2022
Comment on lines
+13
to
+25
| const messageQueue = new AsyncQueue<SocialEvent>((_, action) => { | ||
| if (action == 'close') { | ||
| avatarMessageObservable.remove(observer) | ||
| } | ||
| }) | ||
| const observer = avatarMessageObservable.add((event) => { | ||
| messageQueue.enqueue({ | ||
| event: event.type, | ||
| payload: JSON.stringify(event) | ||
| }) | ||
| }) | ||
| return messageQueue | ||
| } |
Contributor
Test this pull request
|
leanmendoza
added a commit
that referenced
this pull request
Jun 15, 2022
* wip * add devtools * wip * wip * mocking decentraland interface * adding events * all scenes running with new rpc * non functional wip * broken wip * fix * fix * remove empty generic response * add protocol-buf in the pipelines * also add in build step * wip * wip * remove debugger * fix: remove events when sending batch * add stats * add fps throttling and add initial rpcContext * get back the devToolAdapter * complete remaining apis * remove old scene runtime with old rpc * fix comms * fix module loading * fix getBootstrapData * log * test hack * fix test * add worker name to RpcClientPort * remove old stuffs * change to a right name * add esModuleInterop option * move 'real' to just the method name and clean code * remove spam log * rollout to 0 in .org * adapt the experimental api * implement SceneStateStorageController * get back Stateful scenes * fix no service * fix builder in world * clean code: remove didStart from EngineAPI * fix lint * merge from main * PR review suggestions (#334) * makefile suggestions * wip * fix avatars * clean and kuruk review. * typed createGenericLogComponent * FIX ME * lint fix * Revert "FIX ME" This reverts commit eedd2c1. * Fix me 2.0 * fix lint * bypass visible avatar test * batched events approach * change .ts generation to .gen.ts and clean. fix hasManyPermissions to get permissions in a unique request * fix circular dependency * fix stats * move new-rpc to runtime clean code, remove eventChannel * clean and pretify code * fix tests * filter transport closed ack error * revert visibleAvatars logic * fix permission loading, ethereumcontroller and parcelidentity apis * fix build * fix bad scenes * remove a level of JSON.parse and JSON.stringify with protocol-buffers * fix ethereum controller * fix signed fetch * fix: avoid starting more than one, and add the event when the cb fails * optimize: send positionChanged and rotationChagned by protocol-buffer * fix raycast * pretify code Co-authored-by: menduz <github@menduz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.