Skip to content
This repository was archived by the owner on Feb 27, 2023. It is now read-only.

chore: add offline~offline realm for testing#392

Merged
menduz merged 2 commits into
mainfrom
fix/350
Aug 2, 2022
Merged

chore: add offline~offline realm for testing#392
menduz merged 2 commits into
mainfrom
fix/350

Conversation

@menduz
Copy link
Copy Markdown
Member

@menduz menduz commented Aug 2, 2022

/changerealm offline~offline

or https://play.decentraland.zone/?kernel-branch=fix/350&realm=offline~offline

What ?

Add offline realm to avoid comms noise. Usefull for testing purpose

@menduz menduz requested a review from a team as a code owner August 2, 2022 00:20
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 2, 2022

Test this pull request

  • This branch can be previewed at https://play.decentraland.zone/?kernel-branch=fix/350
  • The @dcl/kernel package can be tested in scenes by running
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/kernel/branch/fix/350/dcl-kernel-1.0.0-2778771301.commit-f607aab.tgz"

@menduz menduz changed the title fix: issue #350 chore: add offline~offline realm for testing Aug 2, 2022
@menduz menduz enabled auto-merge (squash) August 2, 2022 15:12
@menduz menduz disabled auto-merge August 2, 2022 15:12
@menduz menduz enabled auto-merge (squash) August 2, 2022 17:26
@menduz menduz merged commit a2fe442 into main Aug 2, 2022
@menduz menduz deleted the fix/350 branch August 2, 2022 17:31
Copy link
Copy Markdown
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

return new QuestsClient({
baseUrl: servers.questsUrl,
authChainProvider: (payload) => Authenticator.signPayload(identity!, payload)
authChainProvider: (payload) => Authenticator.signPayload(identity!, payload) as any
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this? 🤔

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

types of the authchain have changed recently, the QuestClient was not updated

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants