This repository was archived by the owner on Feb 27, 2023. It is now read-only.
pr feedback#465
Merged
Merged
Conversation
menduz
commented
Aug 31, 2022
| export function processVoiceFragment(message: Package<VoiceFragment>) { | ||
| const state = store.getState() | ||
| const voiceHandler = getVoiceHandler(state) | ||
| const profile = getCurrentUserProfile(state) |
Member
There was a problem hiding this comment.
This code is from opus voice chat. I just moved it from the sagas to this new file. I tried to modify it least as possible.
Contributor
Test this pull request
|
kuruk-mm
approved these changes
Aug 31, 2022
kuruk-mm
added a commit
that referenced
this pull request
Sep 8, 2022
* w * checkpoint * wip * wip * split voice chat sagas * wip * wip * checkpoint: new voice sagas working with opus * delete old voice sagas * add missing libopus.wasm.js add livekit voice handler * fix * change token handle * update unity-renderer * livekit with custom and temporal server to get token * improve livekit voice chat * room names by realm and island * todo comment * better logs * fix: remove initialization of voice chat sagas from kernel (#453) * feat: add spatial sound (need more test) feat: add ff for livekit connection (independent from transport) * checkpoint * working for chrome * remove logs * typo * fix ff * fix * fix * remove undefined type * use ff * minor issues (#465) Co-authored-by: menduz <github@menduz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
...
Why?
...