This repository was archived by the owner on Feb 27, 2023. It is now read-only.
fix: do not send channel member update on every member#701
Merged
Conversation
Contributor
Test this pull request
|
Julieta11
approved these changes
Nov 14, 2022
Contributor
Julieta11
left a comment
Julieta11
left a comment
There was a problem hiding this comment.
Great catch, Guido! 🏄🏼
leanmendoza
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #689
Probably solves #688
What?
Remove the listener where every member change is sent to Explorer.
Why?
In cases like joining a big channel is not well handled, sending N updates, where N is the number of members of that channel.
The changes now are only sent when requested by Explorer.