This repository was archived by the owner on Feb 27, 2023. It is now read-only.
feat: add analyticsKernelService with renderer-protocol#728
Merged
Conversation
Contributor
Test this pull request
|
kuruk-mm
force-pushed
the
feat/analytics
branch
from
90d7caf to
f50fbe5
Compare
kuruk-mm
commented
Dec 2, 2022
| const transport = webTransport({ wasmModule: originalUnity.Module }, (globalThis as any).DCL) | ||
|
|
||
| await engineStartedFuture | ||
| await browserInterface.startedFuture |
Member
Author
There was a problem hiding this comment.
this was preventing the RPC from starting...
this is already being awaited here:
kernel/packages/unity-interface/dcl.ts
Line 48 in e9c174b
Member
There was a problem hiding this comment.
Does it still work in desktop? I remember this was a bugfix
pbosio
approved these changes
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add analyticsKernelService using renderer-protocol
Why?
...