feat: implement analytics with renderer protocol#81
Merged
Conversation
Test this pull request
|
kuruk-mm
force-pushed
the
feat/analytics
branch
from
ce6664b to
4d33ec6
Compare
pbosio
reviewed
Nov 29, 2022
| fixed32 system_memory_size = 6; | ||
|
|
||
| // TODO: remove useBinaryTransform after ECS7 is fully in prod | ||
| bool use_binary_transform = 7; |
Contributor
There was a problem hiding this comment.
I think we could remove this already and safely assume renderer will always expect a binary transform, since a really loooong time has passed since we did that change
pbosio
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.