Release 2023-08-16 #5593
Merged
Release 2023-08-16 #5593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Integrate single sign on * fix: Update client * fix: Update client * fix: Update single sign on client * fix: Update client * feat: Update sso client * feat: Update sso client * feat: Sso url by query param * fix: Update package
## What does this PR change? This PR polishes CameraReel and Screencapture features (for the InWorld Camera initiative). It includes major refactoring of both components. On screencapture side - Cinemachine was introduced in Camera movement logic - Screenshot capturing HDR fixed, but with heavy texture upsacle, crop and resize operations - Name tags added also to Avatar On Camera Reel (Gallery) there were a lot of refactoring and polishing, adding transition and missing logic - Metrics were also added ## How to test the changes? You can follow this page to check all requirements https://www.notion.so/decentraland/In-World-Camera-736683ff6b2d4532ad71c873f7de522d - ScreenCapture 1. Launch the explorer 2. Open screencapture camera by button below minimap or via keyboard C 3. Position camera by moving it (see shortcuts in the bottom-left). Check that you cannot pass through colliders and that you cannot go super far away (it should be bounded by sphere around of the player ~16 meters) 4. Check that all buttons in this view are functional - you can take close it, show/hide shortcut panel, take screenshot (animation should be there with SFX), and open CameraRell - CameraReel Gallery 1. Open Gallery via shortcut K or in the ExploreMenu 2. Check sorting of the images and that new pictures added as first (at the top-left). 3. Check that you can delete/copy link/share twitter from the 3 dots on each picture 4. Check that downloaded resolution of pictures is 1920x1080 no matter what resolutions was your screen - CameraReel Screenshot Viewer 1. Open one screenshot from the Gallery by clicking on it 2. Verify that you can see persons and wearables info on the ride panel 3. Verify that you can jump to a place by clicking on the Scene button in the right panel 4. Veriy that you can open Marketplace by clicking on the Wearables from the list
Co-authored-by: Agustina Aldasoro <agusaldasoro@users.noreply.github.com>
chore: sync main to dev
* Feat: rework of explore panel * Minor changes to places panel UI * Added visit count and user rating, removed additional highlights * Minor UI fix * Minor fix to retrieve favorites * Removed highlights tab and added upvote/downvote logic * Added upvote and downvote states * Show more button fixes * Minor UI adaptations to new places card * Added filter and sorting options * Fixed place modal and test * Implement "SortBy" dropdown * Fix favorite button in place cards * Add SORT BY title & fix anchors * Update like icon in the place card * Update like icon in the place card (II) * Full redesign of place card modal * Add “like percentage” tooltip in the place card modal * Fix tests * Full width for the events container * Add and load filter controls (UI) * Minor fixes in Places section * Make Events section load upcoming by default * Make Events section load upcoming by default (II) * New filters: "Featured", "Trending" and "Want to go" * Fix names in the category dropdown filter * New filters: "Frequency" and "Category" * Fix tests * Fix tests * Create RangeSlider extension class * Fix tests * Update TexturesUI.spriteatlas * Update frequency filter's query * Test * Revert "Test" This reverts commit 65acd87. * Fix build * Create new RangeSlider UI Components * Add Time dropdown filter UI control in Events section * New filter: "Time" * Fix tests * UI re-design of the event's card (part 1) * Minor fixes * Minor fixes * Add number of users in event card * Fix POI filters in Places section * Always we filter by POI/FEATURED, we will change the sorting to HIGH RATED * Minor fixes in the Events section * Re-design event modal * Revert "Re-design event modal" This reverts commit c1f41b5. * Re-design event modal (I) * Re-design event modal (II) * Use new endpoint to get all POIs * Fix tests * Apply visual feedback (I) * Fix weird line in the hover of the cards * Update POI's endpoint * Fix weird line in the hover of the cards (II) * Add hover states to the filter buttons * Manage guest mode * Add hover states to the place card buttons * Make the whole cards clickable * Load only event's categories in use * Update EventCard_Long.prefab * Code cleaning * Apply visual feedback (II) * Some polishments * Update PlaceCardComponentView.cs * Update ExploreV2Menu.prefab * Add secondary jumpin button in event card modal * Set a length limit to the event's title * Apply code review's feedback * Fix tests * Add metrics for like/dislike places * Manage guests for fav/like/dislike * Manage guests for fav/like/dislike (II) * Fix dragger helper in places sub-section * Reset scroll position for place/event modal * Fix tests * Featured events carousel polishments * Some polishments * More polishments --------- Co-authored-by: Santi Andrade <sandrade@decentraland.org>
Contributor
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
Fix leave icon
## What does this PR change? Replaced waitForEndOfFrame and unity built screenshot feature by Rendering into RenderTexture that solves black screenshots issue. It is not optimized and optimization will continue on [this branch](#5594), by replacing Creation/Destruction logic with RenderTexture.Get/ReleaseTemporary calls and caching ## How to test the changes? 1. Launch the explorer 2. Open screenshot camera (C) 3. Spam shot screenshots like crazy 🤪 4. Verify no black screenshots are taken 5. Verify no missing transition animations when taking screenshots 6. Verify screenshot image is the same as frame view and has 1920x1080 resolution and looks same (or better) as in-game view (has Bloom, Ambient occlusion, etc.) ## Our Code Review Standards https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md ## Copilot summary <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at aea1e5d</samp> This pull request enhances the screenshot feature by using the Universal Render Pipeline to render and crop the camera output, and by refactoring the SkyboxCamera and ScreenRecorder classes to improve the code quality and the skybox rendering. It also updates the assembly definitions to include the necessary references.
Kinerius
force-pushed
the
release/release-20230816
branch
from
dc99659 to
45f52d0
Compare
Kinerius
approved these changes
Aug 16, 2023
github-actions
bot
requested review from
davidejensen,
kwsskulinski and
mikhail-dcl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Release for 64th August 2023
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
🤖 Generated by Copilot at 56e7d9e
This pull request updates the lambdas, places, and wearables catalog services to support extra query parameters and cancellation tokens for more flexible and controlled requests. It also adds analytics events for the places API, updates the UI and logic of the experiences confirmation popup, and adds a new asset group for duplicate asset isolation.