-
Notifications
You must be signed in to change notification settings - Fork 277
build: Bump cheqd driver to v3.7.4 #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Bump cheqd driver to v3.7.4 #468
Conversation
|
@ankurdotb @peacekeeper Version |
|
This may be a bug in the Universal Resolver itself, I will take a look.. |
|
A bit confused indeed, so do let me know. I tried it with that Accept header on Postman and seemed to work 🤔 |
|
Added a minor version bump to v3.7.2., which has a dependency update + a minor bugfix in one condition where the the media type was not being checked correctly. |
|
@ankurdotb The driver returns something like this: The problem is the We could update the Universal Resolver logic to also support But as a quick fix, perhaps you could update this value in the driver? |
|
Also, I agree with everything in your comment #468 (comment), but I'm not sure if the driver actually behaves in this way. E.g. if I try: Then the driver still returns a DID resolution result including metadata, rather than just the DID documen itself? |
|
Yep we can update the driver, but sorry I might have misunderstood from the chat: I thought the correct resolution profile from our discussions was supposed to be |
|
@peacekeeper Hopefully resolved two issues in this latest commit (release version changed to v3.7.4):
|
In this case you should return the plain DID document itself, NOT wrapped inside a "didDocument" key. Wrong: Correct (the plain DID document itself): If you can make this additional change, I think we're done.. |
|
Okay thanks, that helps disambiguate - I'll mark this as draft until we get that new release ready |
|
@peacekeeper Should be all fixed now, resetting to ready for review |
Key changes
This release addresses feedback regarding the current state that dealing with DID-Linked Resources (DLR) typically requires two API calls:
This release allows, for certain
Acceptheader profiles, for both the DLR and its metadata to be fetched in a single call. We've also maintained backwards compatibility with current behaviour when no specific header is provided or DID Documents/DLRs fetched in the browser.Supporting more granular ways of fetching DID Documents and DID-Linked Resources will offer developers greater control when fetching resolution/dereferencing results.
For DID Resolution
Accept: application/ld+json;profile="https://w3id.org/did-resolution": Returns DID Document + DID Document metadata with DID-Linked Resource metadataAccept: application/did+json,application/did, orapplication/did+ld+json: Returns DID Document only, no DID Document metadataAccept: */*or accessing via browser: → Returns DID Document + DID Document metadata with DID-Linked Resource metadataresourceMetadata=false: Returns DID Document + DID Document metadata without DID-Linked Resource metadataFor DID URL Dereferencing
Accept: application/ld+json;profile="https://w3id.org/did-url-dereferencing": Returns DID-Linked Resource (Base64-encoded) and its metadata in a single responseAccept: */*, specific Accept header (e.g.,Accept: application/json), or accessing via browser: Keeps existing behaviour, returning only the DID-Linked ResourceGeneral improvements
Acceptheader, you can now useqvalues to prioritise preferred IANA media types in response and this will be respected.invalidDidUrlerror is now thrown instead of attempting to resolve to first matching DID-Linked ResourcecontentMetadatarather thancontentStream. Only the actual DID-Linked Resource, if requested in body in Base64-encoding, is returned incontentStreamFull changelog
https://github.com/cheqd/did-resolver/releases/tag/v3.7.0