Skip to content

docs/group.md#80

Merged
yijun-lee merged 4 commits intodraftfrom
docs/group.md
Jan 5, 2025
Merged

docs/group.md#80
yijun-lee merged 4 commits intodraftfrom
docs/group.md

Conversation

@hunjyeong
Copy link
Copy Markdown
Collaborator

@hunjyeong hunjyeong commented Nov 30, 2024

What does this PR do?

Basic Algebra > Group 부분 조금 수정했습니다.
Abelian group은 group에 같이 넣으면 좋을 것 같아서, Basic Algebra에 있던 리스트에서 제외시키고, group에 같이 넣어뒀습니다.
잘못된 부분이나 좀 더 명확한 내용이 필요한 부분 피드백 주시면 감사하겠습니다!

Before reviewing

  • Check for missing / redundant content
  • Grammar Check
  • Check if the content is accurate

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yijun-lee

@yijun-lee
Copy link
Copy Markdown
Member

개선해주셔서 감사합니다!
혹시, Abelian Group을 Group에 합친 이유를 알 수 있을까요?

@hunjyeong
Copy link
Copy Markdown
Collaborator Author

해당 부분은 group 중에서 + commutative 성질만 더 만족하면 abalian group이 되기 때문에 같이 설명하는 것이 더 보기 좋다고 생각했습니다!

@yijun-lee
Copy link
Copy Markdown
Member

@healthykim 혹시 어떻게 생각하시나요!

@healthykim
Copy link
Copy Markdown
Member

제가 확인이 늦었는데 옵시디언으로 블로그를 운영하면 최대한 각 문서를 작게 유지하는 것이 좋긴 한데요, 너무 작아도 흐름이 끊기니 일단 합친 뒤에 너무 길어지면 나누는 걸로 하죠! 잘 합친 것 같습니다 👍

@yijun-lee yijun-lee merged commit d95082f into draft Jan 5, 2025
@yijun-lee yijun-lee deleted the docs/group.md branch January 5, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants