Docs: Added Commutative Ring.md, Division Ring.md and Field.md#87
Merged
yijun-lee merged 3 commits intodecipherhub:draftfrom Feb 17, 2025
Merged
Docs: Added Commutative Ring.md, Division Ring.md and Field.md#87yijun-lee merged 3 commits intodecipherhub:draftfrom
yijun-lee merged 3 commits intodecipherhub:draftfrom
Conversation
In Basic Algebra, to describe field, added commutative ring and division ring
yijun-lee
requested changes
Feb 13, 2025
Member
yijun-lee
left a comment
There was a problem hiding this comment.
기여 감사합니다! 내용 좋은 것 같아요 ㅎㅎ
가능하시다면 'Basic Algebra.md'에 작업해주신 파일에 대한 링크를 추가해주시겠어요? (Field의 링크가 작동하지 않네요!)
Contributor
Author
|
comment 남겨주셔서 감사합니다! "Commutative Ring"과 "Division Ring"을 "Basic Algebra.md"에 추가하였습니다. 그리고 Field의 링크가 작동하지 않는다고 말씀하셨는데 Field.md 안에서 다른 파일에 대한 링크가 작동하지 않는다는 말씀이실까요? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Basic Algebra에서 Field의 설명이 누락되어 있어, Field.md를 작성해 보았습니다.
Field를 설명하기 전에 Commutative Ring과 Division Ring의 설명이 필요하여 이 또한 작성하였습니다.
Field는 암호학에서 중요한 개념중 하나이므로 신중하게 작성되어야 하지 않을까 싶습니다.
부족한 점이 많겠으나 수정, 보완이 필요한 부분 피드백 주시면 감사하겠습니다.
Before reviewing
Who can review?
@yijun-lee @hunjyeong