fix: correct depth tracking in CallTracer only_top_call mode #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CallTracerwhenonly_top_callis enabledProblem
When
only_top_callwas enabled:push_frameskipped nested calls without incrementing depthpop_framecheckeddepth > 1which was false (depth stayed at 1)Fix
Now depth is incremented before the early return check, so
pop_framecorrectly skips nested call endings.Test
crates/execution/src/inspector/call_tracer.rsReported by @qj0r9j0vc2 in PR #115