fix: WebSocket unwrap panic and use OsRng for crypto (#128, #130) #152
+31
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.unwrap()with proper error handling in WebSocket subscription handlersOsRnginstead ofthread_rng()for cryptographic IV/salt generationChanges
pubsub.rs (Issue #128)
Replaced 5 occurrences of panic-prone code:
cipher.rs & kdf.rs (Issue #130)
Changed random number generator for cryptographic operations:
OsRngdirectly uses the operating system's cryptographically secure random number generator, which is the recommended practice for generating cryptographic material like IVs and salts.Test Plan
cargo checkpassesCloses #128
Closes #130