[controller] Enforce CephClusterConnection spec.cephFS immutability via CEL (safe when cephFS is absent)#75
Merged
Conversation
AleksZimin
changed the title
astef
approved these changes
Aug 14, 2025
duckhawk
pushed a commit
that referenced
this pull request
Mar 2, 2026
…ia CEL (safe when cephFS is absent) (#75) Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
duckhawk
added a commit
that referenced
this pull request
May 13, 2026
The check_previous_channel_release composite action now swaps the domain of module_source with its `registry` input before pulling, so the previous-channel image can be read from a read-only registry mirror without changing the deploy target. Pass `vars.PROD_REGISTRY_READ` to take advantage of that. Depends on the swap-domain change in deckhouse/modules-actions (PR #75 for v14).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
spec.cephFSfully immutable (cannot be added, removed, or changed after creation).cephFSto avoid validation errors during controller updates:oldSelf == null || (has(self.spec.cephFS) == has(oldSelf.spec.cephFS) && (!has(self.spec.cephFS) || self.spec.cephFS == oldSelf.spec.cephFS))spec.cephFS.subvolumeGroupimmutability as-is.No restarts of critical components are expected.
Why do we need it, and what problem does it solve?
spec.cephFSwhen the controller tried to add a finalizer (validation referenced a missing key).cephFSblock and setting a different value later, since changing the CephFS subvolume group affects data placement/behavior.cephFSremain valid during normal controller updates.What is the expected result?
spec.cephFSworks; the controller can add finalizers and update status without validation errors.spec.cephFSafter creation is rejected with a clear validation message.spec.cephFS.subvolumeGroupwas set on creation, it remains immutable as before.Checklist