Skip to content

[deckhouse-cli] fix: dcql and pull#357

Merged
ldmonster merged 4 commits into
mainfrom
fix/dcql-and-pull
May 20, 2026
Merged

[deckhouse-cli] fix: dcql and pull#357
ldmonster merged 4 commits into
mainfrom
fix/dcql-and-pull

Conversation

@ldmonster
Copy link
Copy Markdown
Collaborator

@ldmonster ldmonster commented May 20, 2026

Summary

  • Fix duplicate image pulls during d8 mirror pull for edition-scoped sources (FE/EE/SE, etc.): platform, modules, and security services now build download-list URLs from GetEditionRoot() instead of the bare registry root, so entries like .../deckhouse/release-channel:stable are no longer enqueued alongside the correct .../deckhouse/fe/release-channel:stable paths.
  • Introduce registry.Service.GetEditionRoot() and keep GetRoot() for services that live outside the edition sub-tree (installer, plugins).
  • Fix duplicate pushes during d8 mirror push: make ImageLayout.AddImage idempotent for the same (tag, digest) pair, and deduplicate OCI layout manifests by io.deckhouse.image.short_tag in the pusher (last descriptor wins).
  • Fix visible flicker in d8 system queue watch by rendering each frame in an alt-screen buffer (cursor home + clear-to-end) instead of clearing the screen before every refresh.

Problem

When pulling from edition-scoped registries (e.g. --source=registry.deckhouse.ru/deckhouse/fe), the download list mixed bare-root and edition-scoped URLs for the same images/channels. That caused redundant network work and confusing logs.

Separately, repeated AddImage calls during platform pulls could append duplicate descriptors with the same short tag to the OCI layout, which then surfaced in push logs as the same tag being pushed multiple times (e.g. [1 / 337] ... cse:v1.73.2 and later [125 / 337] ... cse:v1.73.2).

ldmonster added 3 commits May 20, 2026 12:32
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
@ldmonster ldmonster self-assigned this May 20, 2026
@ldmonster ldmonster added the bug Something isn't working label May 20, 2026
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
@ldmonster ldmonster merged commit eb7278a into main May 20, 2026
5 checks passed
@ldmonster ldmonster deleted the fix/dcql-and-pull branch May 20, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant