Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the module license linter to skip files with unsupported/unknown types (instead of reporting them as license violations), and simplifies LicenseInfo by moving invalid-license conditions to errors.
Changes:
- Change
LicenseParser.ParseFileto returnErrUnsupportedFileTypefor unknown file types and return errors for invalid/missing licenses (instead ofLicenseInfo.Valid/Errorfields). - Update
LicenseRule.CheckFilesto skip unsupported file types and report other parse errors as lint errors. - Update license parser tests to use
wantErrand pointer*LicenseInfo; mark logger wrappers deprecated and disable SA1019 in golangci-lint.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/linters/module/rules/license_parser.go | Changes parser API: sentinel error for unsupported types; errors for missing/unknown licenses; trims LicenseInfo fields. |
| pkg/linters/module/rules/license.go | Skips unsupported file types based on ErrUnsupportedFileType; reports other parse errors. |
| pkg/linters/module/rules/license_parser_test.go | Adapts tests to new error-based API and pointer LicenseInfo expectations. |
| internal/logger/logger.go | Marks logger.*F wrapper functions as deprecated in favor of slog. |
| .golangci.yml | Disables SA1019 globally to avoid deprecation warnings from logger wrapper usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pavel Okhlopkov <36456348+ldmonster@users.noreply.github.com>
RottenRat
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When unknown file without license - skip