Skip to content

Conversation

@astef
Copy link
Member

@astef astef commented Sep 9, 2025

What's done:

  • go get -t -u ./... && go mod tidy
  • re-generate mocks
  • fix simple compilation errors (see changes in internal/hook/go_hook.go and *_test.go files)
  • recursively run go mod tidy for go modules in examples/

Why it's needed:

Something has happened to one of the Go dependencies (I didn't investigate properly) and build has failed: https://github.com/deckhouse/sds-replicated-volume/actions/runs/17597020020/job/49991504075?pr=255

# github.com/deckhouse/module-sdk/internal/hook
/go/pkg/mod/github.com/deckhouse/module-sdk@v0.3.8/internal/hook/go_hook.go:27:26: cannot
use log.Options{} (value of struct type "github.com/deckhouse/deckhouse/pkg/log".Options) as
"github.com/deckhouse/deckhouse/pkg/log".Option value in argument to log.NewLogger

This PR fixes the build.

- re-generate mocks
- fix simple compilation errors

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
@astef astef marked this pull request as ready for review September 9, 2025 23:27
@astef astef requested a review from ldmonster September 9, 2025 23:27
@ldmonster
Copy link
Collaborator

closed because of this PR #72

@ldmonster ldmonster closed this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants