fix(go_modules_check): tolerate deckhouse monorepo in go list -m all#71
Merged
Merged
Conversation
- Export GOFLAGS=-e so go list -m all does not fail on synthetic transitive pseudo-versions under github.com/deckhouse/deckhouse. - Skip placeholder v0.0.0-00010101000000-000000000000 and paths github.com/deckhouse/deckhouse/* (api/* pseudo check does not apply). - Skip root github.com/deckhouse/deckhouse pins that are not v0.0.0-<14-digit time>-<12-hex> (script only validates that shape). - Point setup-go module cache at **/go.sum (no root go.sum required). Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>
Module repos often have no root go.sum; caching is optional and not required for the go list / pseudo-tag checks. Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>
himax1991
approved these changes
Apr 27, 2026
Nikolay1224
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
go_modules_checkrunsgo list -m all | grep deckhouse. For modules thatrequire github.com/deckhouse/deckhouse, Go 1.25+ can report transitive module lines such asgithub.com/deckhouse/deckhouse/dhctl@v0.0.0-00010101000000-000000000000that makego list -m allexit non-zero, so the composite step fails before any pseudo-tag logic.actions/setup-goalso warned when there is no rootgo.sumfor cache.Change
GOFLAGS=-eso the module graph loads despite those synthetic entries.v0.0.0-00010101000000-000000000000and anygithub.com/deckhouse/deckhouse/*path (the script’sapi/*clone heuristic does not apply to in-repo submodule paths).github.com/deckhouse/deckhouserequire when the version is notv0.0.0-<14-digit time>-<12-hex>(the only shape this action can validate today).cache-dependency-path: **/go.sum.Backport
Same commit is on
fix/go-modules-check-deckhouse-monorepo-v12for a PR intov12(see separate PR).